Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbaBMSnF (ORCPT ); Thu, 13 Feb 2014 13:43:05 -0500 Received: from stinky.trash.net ([213.144.137.162]:42148 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbaBMSnC (ORCPT ); Thu, 13 Feb 2014 13:43:02 -0500 Date: Thu, 13 Feb 2014 18:42:54 +0000 From: Patrick McHardy To: Cong Wang Cc: Jozsef Kadlecsik , Ilia Mirkin , netdev , "linux-kernel@vger.kernel.org" , Vitaly Lavrov Subject: Re: ip_set: protocol %u message -- useful? Message-ID: <20140213184254.GF14175@macbook.localnet> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 13, 2014 at 10:32:45AM -0800, Cong Wang wrote: > On Thu, Feb 13, 2014 at 2:30 AM, Jozsef Kadlecsik > wrote: > > On Thu, 13 Feb 2014, Ilia Mirkin wrote: > >> messages in my dmesg. This might be because of some local > >> configuration changes I've made, or perhaps a kernel upgrade. Either > >> way, it appears this message has been a pr_notice since the original > >> code added it in a7b4f989a62 ("netfilter: ipset: IP set core > >> support"). > >> > >> Does this message provide a lot of value? Or could it be made into a pr_debug? > > > > That's a report message on the protocol version used by the ipset > > subsystem. There was (and possibly will be) multiple protocols, so it > > helps to catch basic userpsace/kernelspace communication issues. > > But still it doesn't deserve a pr_notice()... pr_info() should be enough. Maybe printing "using protocol version X" will make it appear less like a debugging message referring to packet contents or something similar. > diff --git a/net/netfilter/ipset/ip_set_core.c > b/net/netfilter/ipset/ip_set_core.c > index de770ec..5ea063f 100644 > --- a/net/netfilter/ipset/ip_set_core.c > +++ b/net/netfilter/ipset/ip_set_core.c > @@ -1945,7 +1945,7 @@ ip_set_net_init(struct net *net) > return -ENOMEM; > inst->is_deleted = 0; > rcu_assign_pointer(inst->ip_set_list, list); > - pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL); > + pr_info("ip_set: protocol %u\n", IPSET_PROTOCOL); > return 0; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/