Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbaBMTDY (ORCPT ); Thu, 13 Feb 2014 14:03:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20214 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbaBMTDW (ORCPT ); Thu, 13 Feb 2014 14:03:22 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1391791751-2533-1-git-send-email-miklos@szeredi.hu> <19258.1392306854@warthog.procyon.org.uk> <20140213162534.GB4026@tucsk.piliscsaba.szeredi.hu> <20106.1392309770@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Miklos Szeredi , Al Viro , Linux-Fsdevel , Kernel Mailing List , Bruce Fields , Christoph Hellwig , Andrew Morton , Zach Brown , Jan Kara , Andy Lutomirski , "mszeredi@suse.cz" Subject: Re: [PATCH 00/13] cross rename v4 Date: Thu, 13 Feb 2014 19:02:41 +0000 Message-ID: <16729.1392318161@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > So what do others that support this do? Looking at the gitweb for > ls.c in coreutils, we find: > > http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/ls.c > > # ifdef DT_WHT > case DT_WHT: type = whiteout; break; > # endif > > so that's presumably what we should use. Whilst that does seem reasonable, what about all the other software that iterates over a directory? Some of that is surely not going to know about DT_WHT. Further, while that may sort whiteouts, what about fallthroughs? There isn't a DT_ symbol for that... Fallthroughs are 'really there' in the sense that they're positive, but they should take on the underlying object type - which in this situation we can't retrieve:-/ I wonder if it would be possible to require filesystems that can store fallthroughs to store the lower type in the upper dentry (ie. there is no fallthrough type per se, but rather fallthrough-to-file, f-to-char, f-to-sym, etc.). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/