Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbaBMT7n (ORCPT ); Thu, 13 Feb 2014 14:59:43 -0500 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:44870 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbaBMT7l (ORCPT ); Thu, 13 Feb 2014 14:59:41 -0500 Date: Thu, 13 Feb 2014 20:59:08 +0100 From: Florian Westphal To: Ilia Mirkin Cc: Patrick McHardy , Cong Wang , Jozsef Kadlecsik , netdev , "linux-kernel@vger.kernel.org" , Vitaly Lavrov Subject: Re: ip_set: protocol %u message -- useful? Message-ID: <20140213195908.GK25153@breakpoint.cc> References: <20140213184254.GF14175@macbook.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ilia Mirkin wrote: > > Maybe printing "using protocol version X" will make it appear less like > > a debugging message referring to packet contents or something similar. > > With pr_info it'll still appear in dmesg, and it'll still be "random > non-sensical message appears over and over in dmesg" type of > situation, to the vast majority of users. Do we need a print every > time someone creates a new tcp connection too? I'm still not totally > clear on the cause of this message getting printed, but I was seeing > it a whole bunch in my configuration... Yes, because it erronously got moved into the netns init function. And thats what causes the spew. Moving it back into module init function should be enough. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/