MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
Message-id: <1392343111.25542.113.camel@kjgkr>
Subject: Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails
 during mkdir syscall
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Andrey Tsyvarev <tsyvarev@ispras.ru>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        linux-f2fs-devel@lists.sourceforge.net
Date: Fri, 14 Feb 2014 10:58:31 +0900
In-reply-to: <52F9DF85.7040402@ispras.ru>
References: <52F320FC.50803@ispras.ru> <1391666564.25542.78.camel@kjgkr>
 <52F37D67.208@ispras.ru> <1391734185.25542.80.camel@kjgkr>
 <1391749933.25542.83.camel@kjgkr> <52F9DF85.7040402@ispras.ru>
Organization: Samsung
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

Hi,

Sorry for the late response.
I suffered from flu during last a couple of days. :(

2014-02-11 (화), 12:29 +0400, Andrey Tsyvarev:
> Hi,
> 
> > It turns out that make_bad_inode prior to iput sets i_mode to a regular
> > file, so that f2fs_evict_inode -> truncate_inode_pages ->
> > f2fs_invalidate_data_page doesn't decrement dirty_dents.
> >
> It seems that remove_dirty_dir_inode() call should also be added to the 
> error-path of
> init_inode_metadata, because its functionality is also based on 
> inode->i_mode field
> which is changed by make_bad_inode().

Agreed.
I'll update the patch with this.
Thanks,

-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/