Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbaBNEx3 (ORCPT ); Thu, 13 Feb 2014 23:53:29 -0500 Received: from mail-qc0-f173.google.com ([209.85.216.173]:65003 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbaBNEx1 (ORCPT ); Thu, 13 Feb 2014 23:53:27 -0500 MIME-Version: 1.0 In-Reply-To: References: <1387953065-2726-1-git-send-email-linkinjeon@gmail.com> <87mwi8x27b.fsf@devron.myhome.or.jp> Date: Fri, 14 Feb 2014 13:53:26 +0900 Message-ID: Subject: Re: [PATCH v3 2/6] fat: add fat_fallocate operation From: Namjae Jeon To: OGAWA Hirofumi Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Amit Sahrawat Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> [...] >> >>> + /* Release unwritten fallocated blocks on inode eviction. */ >>> + if (MSDOS_I(inode)->mmu_private < MSDOS_I(inode)->i_disksize) { >>> + int err; >>> + fat_truncate_blocks(inode, MSDOS_I(inode)->mmu_private); >>> + /* Fallocate results in updating the i_start/iogstart >>> + * for the zero byte file. So, make it return to >>> + * original state during evict and commit it >>> + * synchrnously to avoid any corruption on the next >>> + * access to the cluster chain for the file. >>> + */ >>> + err = fat_sync_inode(inode); >> >> Ah, good catch. We have to update i_size. I was forgetting about this. >> Well, sync inode unconditionally would not be good. Maybe, we better to >> use __fat_write_inode() with inode_needs_sync() or such. > Okay, I will change it. Hi OGAWA When I checked more, we should wait till inode is sync. Because in the eviction it will leave the inode/buffers being marked dirty. Not waiting for it get sync over here. It will leave cluster chain corrupted when remounting. It mean we cannot use __fat_write_inode with inode_needs_sync() conditionally. Thanks. > > Thanks. >> -- >> OGAWA Hirofumi >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/