Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbaBNSvL (ORCPT ); Fri, 14 Feb 2014 13:51:11 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:63670 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbaBNSvH (ORCPT ); Fri, 14 Feb 2014 13:51:07 -0500 Date: Fri, 14 Feb 2014 11:51:04 -0700 From: Bjorn Helgaas To: Jason Cooper Cc: Thomas Petazzoni , Jean-Jacques Hiblot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gregory.clement@free-electrons.com, linux-pci@vger.kernel.org Subject: Re: [PATCH] mvebu : pcie: dt: potential issue in range parsing Message-ID: <20140214185103.GE31093@google.com> References: <1389349431-7997-1-git-send-email-jjhiblot@traphandler.com> <20140205164710.082f689e@skate> <20140205172107.GU8533@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140205172107.GU8533@titan.lakedaemon.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 05, 2014 at 12:21:07PM -0500, Jason Cooper wrote: > > + Bjorn, linux-pci > > Bjorn, > > It looks like this didn't get Cc'd to linux-pci. Here's a link: > > http://www.spinics.net/lists/arm-kernel/msg299721.html Thanks for the heads-up; I had indeed missed this (I mostly rely on patchwork, which only tracks linux-pci, and it's not smart enough to extract quoted patches). Applied to pci/host-mvebu for v3.15, thanks! > > On Wed, Feb 05, 2014 at 04:47:10PM +0100, Thomas Petazzoni wrote: > > Dear Jean-Jacques Hiblot, > > > > On Fri, 10 Jan 2014 11:23:51 +0100, Jean-Jacques Hiblot wrote: > > > The second parameter of of_read_number is not the index, but a size. > > > As it happens, in this case it may work just fine because of the the conversion > > > to u32 and the favorable endianness on this architecture. > > > > > > Signed-off-by: Jean-Jacques Hiblot > > > --- > > > drivers/pci/host/pci-mvebu.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c > > > index c269e43..877e8ce 100644 > > > --- a/drivers/pci/host/pci-mvebu.c > > > +++ b/drivers/pci/host/pci-mvebu.c > > > @@ -768,7 +768,7 @@ static int mvebu_get_tgt_attr(struct device_node *np, int devfn, > > > > > > for (i = 0; i < nranges; i++) { > > > u32 flags = of_read_number(range, 1); > > > - u32 slot = of_read_number(range, 2); > > > + u32 slot = of_read_number(range + 1, 1); > > > u64 cpuaddr = of_read_number(range + na, pna); > > > unsigned long rtype; > > > > > > > Sorry for the long delay, and thanks for the fix! > > > > Acked-by: Thomas Petazzoni > > Tested-by: Thomas Petazzoni > > > > (on Armada 370, with PCIe cards plugged in) > > > Fixes: 11be65472a427 ("PCI: mvebu: Adapt to the new device tree layout") > Cc: # v3.12+ > Acked-by: Jason Cooper > > thx, > > Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/