Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbaBNTCv (ORCPT ); Fri, 14 Feb 2014 14:02:51 -0500 Received: from mail-ve0-f178.google.com ([209.85.128.178]:51806 "EHLO mail-ve0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbaBNTCu (ORCPT ); Fri, 14 Feb 2014 14:02:50 -0500 MIME-Version: 1.0 In-Reply-To: <20140213112606.GF20717@console-pimps.org> References: <1391619853-10601-1-git-send-email-leif.lindholm@linaro.org> <1391619853-10601-7-git-send-email-leif.lindholm@linaro.org> <20140213112606.GF20717@console-pimps.org> Date: Fri, 14 Feb 2014 11:02:49 -0800 Message-ID: Subject: Re: [PATCH 06/22] Add helper functions used by arm/arm64 From: Roy Franz To: Matt Fleming Cc: Leif Lindholm , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-efi@vger.kernel.org" , Patch Tracking Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 13, 2014 at 3:26 AM, Matt Fleming wrote: > On Wed, 05 Feb, at 05:03:57PM, Leif Lindholm wrote: >> From: Roy Franz >> >> Add the get_dram_base() function and efi_call_physN() macros >> that are shared by arm/arm64. >> >> Signed-off-by: Roy Franz >> Signed-off-by: Leif Lindholm >> --- >> drivers/firmware/efi/efi-stub-helper.c | 63 +++++++++++++++++++++++++------- >> 1 file changed, 50 insertions(+), 13 deletions(-) > > These changes should be in drivers/firmware/efi/arm-stub.c - > efi-stub-helper.c is not a dumping ground for random > architecture-specific code. Hi Matt, I will move those functions/macros to the arm-stub.c file. I agree that the macros should go there, as they are the arm specific versions and conflict with the x86 versions defined elsewhere. These were there before the arm-stub.c file was added and didn't get moved when it was. The get_dram_base() function is only used by arm/arm64, but there is nothing architecture specific about it, which is why I put it here to begin with. I don't feel strongly about this either way. Thanks, Roy > > -- > Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/