Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328AbaBNWEb (ORCPT ); Fri, 14 Feb 2014 17:04:31 -0500 Received: from mail-qa0-f42.google.com ([209.85.216.42]:54595 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbaBNWE2 (ORCPT ); Fri, 14 Feb 2014 17:04:28 -0500 Date: Fri, 14 Feb 2014 17:04:24 -0500 From: Tejun Heo To: Greg Kroah-Hartman Cc: Li Zefan , Cgroups , LKML Subject: Re: [PATCH] kernfs: fix kernfs_node_from_dentry() Message-ID: <20140214220424.GA4634@mtj.dyndns.org> References: <52FDDA77.6070606@huawei.com> <20140214160301.GE31544@htj.dyndns.org> <20140214220440.GA3998@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140214220440.GA3998@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2014 at 02:04:40PM -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 14, 2014 at 11:03:01AM -0500, Tejun Heo wrote: > > On Fri, Feb 14, 2014 at 04:57:27PM +0800, Li Zefan wrote: > > > Currently kernfs_node_from_dentry() returns NULL for root dentry, > > > because root_dentry->d_op == NULL. > > > > > > Due to this bug cgroupstats_build() returns -EINVAL for root cgroup. > > > > > > # mount -t cgroup -o cpuacct /cgroup > > > # Documentation/accounting/getdelays -C /cgroup > > > fatal reply error, errno -22 > > > > > > With this fix: > > > > > > # Documentation/accounting/getdelays -C /cgroup > > > sleeping 305, blocked 0, running 1, stopped 0, uninterruptible 1 > > > > > > Signed-off-by: Li Zefan > > > > Acked-by: Tejun Heo > > Is this needed for 3.14-final or 3.15-rc1? 3.15-rc1, so, driver-core-next. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/