Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbaBNXTG (ORCPT ); Fri, 14 Feb 2014 18:19:06 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:45675 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbaBNXTE (ORCPT ); Fri, 14 Feb 2014 18:19:04 -0500 Date: Fri, 14 Feb 2014 15:19:02 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Joonsoo Kim cc: Pekka Enberg , Christoph Lameter , Andrew Morton , Wanpeng Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH 3/9] slab: move up code to get kmem_cache_node in free_block() In-Reply-To: <1392361043-22420-4-git-send-email-iamjoonsoo.kim@lge.com> Message-ID: References: <1392361043-22420-1-git-send-email-iamjoonsoo.kim@lge.com> <1392361043-22420-4-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Feb 2014, Joonsoo Kim wrote: > node isn't changed, so we don't need to retreive this structure > everytime we move the object. Maybe compiler do this optimization, > but making it explicitly is better. > Would it be possible to make it const struct kmem_cache_node *n then? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/