Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753467AbaBOQrH (ORCPT ); Sat, 15 Feb 2014 11:47:07 -0500 Received: from top.free-electrons.com ([176.31.233.9]:33142 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753430AbaBOQrG (ORCPT ); Sat, 15 Feb 2014 11:47:06 -0500 Date: Sat, 15 Feb 2014 17:46:58 +0100 From: Alexandre Belloni To: Masanari Iida Cc: linux-kernel@vger.kernel.org, mturquette@linaro.org, nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org, b.brezillon@overkiz.com Subject: Re: [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup() Message-ID: <20140215164658.GI2932@piout.net> References: <1392124507-14463-1-git-send-email-standby24x7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392124507-14463-1-git-send-email-standby24x7@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2014 at 22:15:07 +0900, Masanari Iida wrote : > cppcheck detected following error > [clk-master.c:245]: (error) Memory leak: characteristics > > The original code forgot to free characteristics when > irq_of_parse_and_map() failed. > > Signed-off-by: Masanari Iida Acked-by: Alexandre Belloni > --- > drivers/clk/at91/clk-master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c > index bd313f7..c1af80b 100644 > --- a/drivers/clk/at91/clk-master.c > +++ b/drivers/clk/at91/clk-master.c > @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, struct at91_pmc *pmc, > > irq = irq_of_parse_and_map(np, 0); > if (!irq) > - return; > + goto out_free_characteristics; > > clk = at91_clk_register_master(pmc, irq, name, num_parents, > parent_names, layout, > -- > 1.9.rc1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/