Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbaBOREM (ORCPT ); Sat, 15 Feb 2014 12:04:12 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:61805 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753441AbaBOREK (ORCPT ); Sat, 15 Feb 2014 12:04:10 -0500 Message-ID: <52FF9E00.90005@samsung.com> Date: Sun, 16 Feb 2014 02:04:00 +0900 From: Kukjin Kim User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 MIME-Version: 1.0 To: Charles Keepax CC: Paul Gortmaker , linux-arch@vger.kernel.org, Kukjin Kim , Russell King , patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, Ben Dooks , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular References: <1390339396-3479-1-git-send-email-paul.gortmaker@windriver.com> <1390339396-3479-20-git-send-email-paul.gortmaker@windriver.com> <20140123131621.GD11589@opensource.wolfsonmicro.com> In-Reply-To: <20140123131621.GD11589@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/14 22:16, Charles Keepax wrote: > On Tue, Jan 21, 2014 at 04:22:22PM -0500, Paul Gortmaker wrote: >> Despite the name mach-crag6410-module.c, the code is built for >> MACH_WLF_CRAGG_6410 -- which is bool, and hence this code is >> either present or absent. It will never be modular, so using >> module_init as an alias for __initcall can be somewhat >> misleading. >> >> Fix this up now, so that we can relocate module_init from >> init.h into module.h in the future. If we don't do this, we'd >> have to add module.h to obviously non-modular code, and that >> would be a worse thing. >> >> Note that direct use of __initcall is discouraged, vs. one >> of the priority categorized subgroups. As __initcall gets >> mapped onto device_initcall, our use of device_initcall >> directly in this change means that the runtime impact is >> zero -- it will remain at level 6 in initcall ordering. >> >> Cc: Ben Dooks >> Cc: Kukjin Kim >> Cc: Russell King >> Cc: patches@opensource.wolfsonmicro.com >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Paul Gortmaker >> --- > > Tested-by: Charles Keepax > Thanks, applied. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/