Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbaBORIU (ORCPT ); Sat, 15 Feb 2014 12:08:20 -0500 Received: from 7.mo2.mail-out.ovh.net ([188.165.48.182]:38013 "EHLO mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753443AbaBORIS (ORCPT ); Sat, 15 Feb 2014 12:08:18 -0500 Message-ID: <52FF9EFC.2060707@overkiz.com> Date: Sat, 15 Feb 2014 18:08:12 +0100 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Masanari Iida , linux-kernel@vger.kernel.org, mturquette@linaro.org CC: nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk:at91: Fix memory leak in of_at91_clk_master_setup() References: <1392124507-14463-1-git-send-email-standby24x7@gmail.com> <52FA2338.3030707@overkiz.com> In-Reply-To: <52FA2338.3030707@overkiz.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 11453498277842680034 X-Ovh-Remote: 78.236.240.82 (cha74-5-78-236-240-82.fbx.proxad.net) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: 0 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrjedvucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecu X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejtddrledtucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mike, Could you take this patch for the next 3.14 release ? Best Regards, Boris On 11/02/2014 14:18, Boris BREZILLON wrote: > On 11/02/2014 14:15, Masanari Iida wrote: >> cppcheck detected following error >> [clk-master.c:245]: (error) Memory leak: characteristics >> >> The original code forgot to free characteristics when >> irq_of_parse_and_map() failed. >> >> Signed-off-by: Masanari Iida > Acked-by Boris BREZILLON > > Thanks for fixing this. > > Best Regards, > > Boris >> --- >> drivers/clk/at91/clk-master.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/at91/clk-master.c >> b/drivers/clk/at91/clk-master.c >> index bd313f7..c1af80b 100644 >> --- a/drivers/clk/at91/clk-master.c >> +++ b/drivers/clk/at91/clk-master.c >> @@ -242,7 +242,7 @@ of_at91_clk_master_setup(struct device_node *np, >> struct at91_pmc *pmc, >> irq = irq_of_parse_and_map(np, 0); >> if (!irq) >> - return; >> + goto out_free_characteristics; >> clk = at91_clk_register_master(pmc, irq, name, num_parents, >> parent_names, layout, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/