Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753697AbaBOTDP (ORCPT ); Sat, 15 Feb 2014 14:03:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:52895 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbaBOTDO (ORCPT ); Sat, 15 Feb 2014 14:03:14 -0500 Date: Sat, 15 Feb 2014 11:04:35 -0800 From: Greg KH To: Jassi Brar Cc: linux-kernel@vger.kernel.org, s-anna@ti.com, tony@atomide.com, omar.ramirez@copitl.com, loic.pallardy@st.com, lftan.linux@gmail.com, slapdau@yahoo.com.au, courtney.cavin@sonymobile.com, rafael.j.wysocki@intel.com, Jassi Brar Subject: Re: [PATCHv3 2/6] mailbox: Introduce a new common API Message-ID: <20140215190435.GB1801@kroah.com> References: <1392488526-17715-1-git-send-email-jaswinder.singh@linaro.org> <1392488727-17981-1-git-send-email-jaswinder.singh@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392488727-17981-1-git-send-email-jaswinder.singh@linaro.org> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote: > +typedef unsigned request_token_t; Ick. Why add a new typedef? And if you do need this, drop the "_t" on the end please. Why not just rely on an unsigned int? Or long? Do you really need a new type? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/