Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbaBOW7x (ORCPT ); Sat, 15 Feb 2014 17:59:53 -0500 Received: from mail-ve0-f182.google.com ([209.85.128.182]:42124 "EHLO mail-ve0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbaBOW7v (ORCPT ); Sat, 15 Feb 2014 17:59:51 -0500 MIME-Version: 1.0 In-Reply-To: References: <87a9kkax0j.fsf@xmission.com> <8761v7h2pt.fsf@tw-ebiederman.twitter.com> <87li281wx6.fsf_-_@xmission.com> <87ob28kqks.fsf_-_@xmission.com> <87bny8kqik.fsf_-_@xmission.com> Date: Sat, 15 Feb 2014 14:59:50 -0800 X-Google-Sender-Auth: H4EkUgCoSPKubDikq6RKGe48gew Message-ID: Subject: Re: [PATCH 02/11] vfs: More precise tests in d_invalidate From: Linus Torvalds To: "Eric W. Biederman" Cc: Al Viro , "Serge E. Hallyn" , Linux-Fsdevel , Kernel Mailing List , Andy Lutomirski , Rob Landley , Miklos Szeredi , Christoph Hellwig , Karel Zak , "J. Bruce Fields" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 15, 2014 at 2:51 PM, Linus Torvalds wrote: > > the whole check_submounts_and_drop thing walks the parent chain and > locks each parent with the renamelock held for writing. Oops, my bad about the write lock, brainfart due to grepping and reading the wrong context... check_submounts_and_drop() doesn't do the parent walk with the rename lock held for writing, it just holds it for reading. But it does do that very complex "walk parents and check all siblings" and locks them, so the rest of the commentary was correct. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/