Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbaBPUC3 (ORCPT ); Sun, 16 Feb 2014 15:02:29 -0500 Received: from netrider.rowland.org ([192.131.102.5]:37209 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753280AbaBPUC2 (ORCPT ); Sun, 16 Feb 2014 15:02:28 -0500 Date: Sun, 16 Feb 2014 15:02:27 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Paul Bolle cc: Greg Kroah-Hartman , Arnd Bergmann , Richard Weinberger , , Subject: Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI In-Reply-To: <1392579941.28866.55.camel@x220> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Feb 2014, Paul Bolle wrote: > USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made > obsolete in v3.11. They have not been used ever since. Setting them has > no effect. They can safely be removed. > > Signed-off-by: Paul Bolle > --- > Tested with "git grep". > > Note that the comment in this Kconfig file (that is also removed) > suggests to first remove the select statements for these symbols and > then the symbols themselves. But I think it makes more sense to first > delete these three symbols and then remove the selects statements (as > that is removing a second order effect). But it could just as well be > done with just one patch, I'd say. There's a simple reason for not getting rid of the symbols first. Doing it that way, as you did, leaves a window in which it's possible to select a non-existent symbol. If that's not an error, it ought to be. Regardless, for both patches: Acked-by: Alan Stern Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/