Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753679AbaBPXcn (ORCPT ); Sun, 16 Feb 2014 18:32:43 -0500 Received: from ozlabs.org ([203.10.76.45]:41511 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbaBPXcm (ORCPT ); Sun, 16 Feb 2014 18:32:42 -0500 From: Rusty Russell To: Steven Rostedt Cc: Ingo Molnar , Mathieu Desnoyers , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , David Howells , Greg Kroah-Hartman Subject: Re: [RFC PATCH] Fix: module signature vs tracepoints: add new TAINT_UNSIGNED_MODULE In-Reply-To: <20140213161156.3548df43@gandalf.local.home> References: <1392074600-21977-1-git-send-email-mathieu.desnoyers@efficios.com> <20140211072738.GA24232@gmail.com> <20140211234534.6bc34e57@gandalf.local.home> <877g8zg0ed.fsf@rustcorp.com.au> <20140213161156.3548df43@gandalf.local.home> User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Fri, 14 Feb 2014 11:21:19 +1030 Message-ID: <878uteecu0.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt writes: > On Thu, 13 Feb 2014 13:54:42 +1030 > Rusty Russell wrote: > > >> I'm ambivalent towards out-of-tree modules, so not tempted unless I see >> a bug report indicating a concrete problem. Then we can discuss... > > As I replied in another email, this is a concrete problem, and affects > in-tree kernel modules. > > If you have the following in your .config: > > CONFIG_MODULE_SIG=y > # CONFIG_MODULE_SIG_FORCE is not set > # CONFIG_MODULE_SIG_ALL is not set This means you've set the "I will arrange my own module signing" config option: Sign all modules during make modules_install. Without this option, modules must be signed manually, using the scripts/sign-file tool. comment "Do not forget to sign required modules with scripts/sign-file" depends on MODULE_SIG_FORCE && !MODULE_SIG_ALL Then you didn't do that. You broke it, you get to keep both pieces. Again: is there an actual valid use case? Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/