Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbaBQCi1 (ORCPT ); Sun, 16 Feb 2014 21:38:27 -0500 Received: from prod-mail-xrelay07.akamai.com ([72.246.2.115]:55739 "EHLO prod-mail-xrelay07.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbaBQCiZ convert rfc822-to-8bit (ORCPT ); Sun, 16 Feb 2014 21:38:25 -0500 From: "Banerjee, Debabrata" To: Linus Torvalds CC: Kay Sievers , Greg Kroah-Hartman , Linux Kernel Mailing List , Jeff Mahoney , "dbavatar@gmail.com" , "Hunt, Joshua" , stable Date: Sun, 16 Feb 2014 21:38:22 -0500 Subject: Re: [PATCH] printk: Fix discarding of records Thread-Topic: [PATCH] printk: Fix discarding of records Thread-Index: Ac8riVOjrlxvkJl1SRGf4JkhYGWY7Q== Message-ID: References: <1392352954-29905-1-git-send-email-dbanerje@akamai.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/16/14, 7:41 PM, "Linus Torvalds" wrote: >On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata > wrote: >> >> No that can't be right, the prev value after every loop is the >>msg->flags >> from the *last* line in the list, which has no relation to the *first*, >>so >> reusing it for the top of the next loop is nonsense. > >Please, Debabrata, humor me, and just try the patch. > >And try reading the source code. Because your statement is BS. ... >No, I haven't tested my patch, and maybe it's broken for some subtle >reason I'm missing too. Yes my explanation was wrong, your patch works for me. I assumed printing the prefix was desired, but if not, great. -Debabrata -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/