Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbaBQFPn (ORCPT ); Mon, 17 Feb 2014 00:15:43 -0500 Received: from mail-oa0-f50.google.com ([209.85.219.50]:65402 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbaBQFPl (ORCPT ); Mon, 17 Feb 2014 00:15:41 -0500 MIME-Version: 1.0 In-Reply-To: <1725957.nHPERWcMfN@vostro.rjw.lan> References: <15ccc0609cb9ee3db0ad3a95b29bf69d11ea197c.1392375504.git.viresh.kumar@linaro.org> <8f2fc4d6240b567fdb69a0b47f073d174b7ef9b2.1392375504.git.viresh.kumar@linaro.org> <1725957.nHPERWcMfN@vostro.rjw.lan> Date: Mon, 17 Feb 2014 10:45:41 +0530 Message-ID: Subject: Re: [PATCH 2/2] cpufreq: don't call cpufreq_update_policy() on CPU addition From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Pierre Ossman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17 February 2014 05:51, Rafael J. Wysocki wrote: > On Friday, February 14, 2014 04:30:41 PM Viresh Kumar wrote: >> cpufreq_update_policy() is called from two places currently. From a workqueue >> handled queued from cpufreq_bp_resume() for boot CPU and from >> cpufreq_cpu_callback() whenever a CPU is added. >> >> The first one makes sure that boot CPU is running on the frequency present in >> policy->cpu. But we don't really need a call from cpufreq_cpu_callback(), >> because we always call cpufreq_driver->init() (which will set policy->cur >> correctly) whenever first CPU of any policy is added back. And so every policy >> structure is guaranteed to have the right frequency in policy->cur. > > That sounds good, but doing the extra cpufreq_update_policy() shouldn't actually > hurt, should it? Yeah, it shouldn't hurt badly.. > So, that would be a cleanup rather than a fix, right? Hmm, yeah.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/