Date: Tue, 5 Nov 2002 16:49:48 +1100
From: Anton Blanchard <anton@samba.org>
To: manfred@colorfullife.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix slab allocator for non zero boot cpu
Message-ID: <20021105054948.GA10335@krispykreme>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1022
Lines: 30


Hi,

The slab allocator doesnt initialise ->array for all cpus. This means
we fail to boot on a machine with boot cpu != 0. I was testing current
2.5 BK.

Luckily Rusty was at hand to explain the ins and outs of initialisers
to me. Manfred, does this look OK to you?

Anton

===== mm/slab.c 1.46 vs edited =====
--- 1.46/mm/slab.c	Sat Nov  2 08:34:38 2002
+++ edited/mm/slab.c	Tue Nov  5 15:55:55 2002
@@ -437,7 +437,8 @@
 /* internal cache of cache description objs */
 static kmem_cache_t cache_cache = {
 	.lists		= LIST3_INIT(cache_cache.lists),
-	.array		= { [0] = &initarray_cache.cache },
+	/* Allow for boot cpu != 0 */
+	.array		= { [0 ... NR_CPUS-1] = &initarray_cache.cache },
 	.batchcount	= 1,
 	.limit		= BOOT_CPUCACHE_ENTRIES,
 	.objsize	= sizeof(kmem_cache_t),
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/