Date: Mon, 17 Feb 2014 10:56:28 +0100
Message-ID: <s5h61oe12r7.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ACPI / video: Add HP EliteBook Revolve 810 to the blacklist"
In-Reply-To: <5301A3AE.9030703@intel.com>
References: <1392381247-28109-1-git-send-email-mika.westerberg@linux.intel.com>
	<s5hy51dzr9f.wl%tiwai@suse.de>
	<20140214152601.GL5018@intel.com>
	<5716481.SxKZLEy9L1@vostro.rjw.lan>
	<5301A3AE.9030703@intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

At Mon, 17 Feb 2014 13:52:46 +0800,
Aaron Lu wrote:
> 
> On 02/15/2014 06:21 AM, Rafael J. Wysocki wrote:
> > On Friday, February 14, 2014 05:26:01 PM Mika Westerberg wrote:
> >> On Fri, Feb 14, 2014 at 03:46:20PM +0100, Takashi Iwai wrote:
> >>> The acpi_osi blacklist is just a workaround, and if we have better
> >>> solutions, it should be removed.  That's why I'm asking it.
> >>>
> >>> So, after removing acpi_osi blacklist, and keeping your video
> >>> blacklist patch, the backlight works?
> >>
> >> Yes, the backlight works (there is only intel_backlight listed under
> >> /sys/class/backlight).
> >>
> >>> If yes, as mentioned, we should think of rather extending this video
> >>> blacklist to more EliteBook G1 and ProBook G1 machines, and remove
> >>> acpi_osi blacklist instead.
> >>
> >> Makes sense to me. (Well, I'm fine as long as backlight on my machine works
> >> ;-))
> >>
> >> Aaron, Rafael, any comments on this?
> > 
> > I generally agree with Takashi, but I'm not sure what to do for 3.14.
> 
> I can re-base the previously sent patch titled:
> [PATCH] ACPI / video: Add systems that should favor native backlight interface
> And put Mika's system into the DMI table that will use native backlight
> interface in video module and remove it from video_detect's DMI table at
> the same time. Does this sound OK?

Rather put more generic DMI entries for the recent HP ProBook and
EliteBook machines as in acpi_osi blacklist:

	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ProBook 2013 models",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook "),
		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP EliteBook 2013 models",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "),
		     DMI_MATCH(DMI_PRODUCT_NAME, " G1"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ZBook 14",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 14"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ZBook 15",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 15"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP ZBook 17",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP ZBook 17"),
		},
	},
	{
	.callback = dmi_disable_osi_win8,
	.ident = "HP EliteBook 8780w",
	.matches = {
		     DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
		     DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
		},
	},

All these are known to have different behavior with Win8, including
the broken ACPI backlight.  Once after merging that patch, we can
revert the commit 2d4054d84224.

I suppose it'd be OK for to do these for 3.14, since the acpi_osi
commit was merged first in 3.14.  Then we can continue fixing in a
saner way.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/