Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbaBQMDf (ORCPT ); Mon, 17 Feb 2014 07:03:35 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:65301 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838AbaBQMDd (ORCPT ); Mon, 17 Feb 2014 07:03:33 -0500 Date: Mon, 17 Feb 2014 12:03:26 +0000 From: Lee Jones To: Roger Cc: Samuel Ortiz , Chris Ball , Greg Kroah-Hartman , Maxim Levitsky , Alex Dubov , Dan Carpenter , Ulf Hansson , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn, micky_ching@realsil.com.cn, Andrew Morton Subject: Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver Message-ID: <20140217120326.GC20218@lee--X1> References: <1392199238-14500-1-git-send-email-rogerable@realtek.com> <1392199238-14500-2-git-send-email-rogerable@realtek.com> <20140214094427.GA7380@lee--X1> <5301A786.8040607@realtek.com> <20140217082222.GA17875@lee--X1> <5301D369.5010100@realtek.com> <20140217100211.GE17875@lee--X1> <5301E376.8010000@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5301E376.8010000@realtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >>>>>>From: Roger Tseng > >>>>>> > >>>>>>Realtek USB card reader provides a channel to transfer command or data to flash > >>>>>>memory cards. This driver exports host instances for mmc and memstick subsystems > >>>>>>and handles basic works. > >>>>>> > >>>>>>Signed-off-by: Roger Tseng > >>>>>>--- > >>>>>> drivers/mfd/Kconfig | 10 + > >>>>>> drivers/mfd/Makefile | 1 + > >>>>>> drivers/mfd/rtsx_usb.c | 760 +++++++++++++++++++++++++++++++++++++++++++ > >>>>>> include/linux/mfd/rtsx_usb.h | 628 +++++++++++++++++++++++++++++++++++ > >>>>>> 4 files changed, 1399 insertions(+) > >>>>>> create mode 100644 drivers/mfd/rtsx_usb.c > >>>>>> create mode 100644 include/linux/mfd/rtsx_usb.h > >>>>> > >>>>>Applied again, thanks. > >>>>> > >>>>Would you also apply patch 2/3 and 3/3 that to make the device fully > >>>>operational for users? Or should they be applied by maintainers of > >>>>mmc/memstick subsystems? > >>>> > >>>>Chris, would you give some comment? > >>> > >>>I can apply them, but I need the other Maintainer Acks. > >>> > >>>If they are build orthogonal i.e. there are no build dependencies > >>>between them, it's probably better that they go into their associated > >>>trees separately. > >>> > >>I think it would be better to apply them together since the later > >>patches really depend on the 1st one,so now we are waiting for Acks > >>from mmc/memstick subsystems. > > > >When you say "depend on", do you mean as a build depenency, or won't > >run without the first patch applied? > > The later 2 patches actually invoke symbols defined in the first > patch and won't compile if it is not applied first. The Kconfig > changes for the later oness also specified this by "depends on". > > I'm not sure if this means "build dependency". Sorry for my unclear words. Yes, that sounds like a build dependency i.e. will not build without errors or warnings without the previous patch applied. > >>But there is no one specified for "memstick/host/" in MAINTAINERS. > >>Could anyone else Ack this? Andrew (CC'ed) has been Acking these thus far. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/