Date: Mon, 17 Feb 2014 15:37:48 +0000
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] serial/uart: Add tunable RX interrupt trigger I/F of
 FIFO buffers
Message-ID: <20140217153748.513230fb@alan.etchedpixels.co.uk>
In-Reply-To: <52FDD470.7000607@hitachi.com>
References: <20140206021655.8613.52786.stgit@yunodevel>
	<20140213181007.GA24155@kroah.com>
	<52FDD470.7000607@hitachi.com>
Organization: Intel Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

> #define TIOCSFIFORTRIG    _IOW('T', 0x41, unsigned char)
> 
> > Also, why pass a pointer to a variable, and not just the value itself?
> 
> Ah, it's no big reason.
> It will pass just the value itself in V2.

We don't need ioctls here - we have a sysfs interface we can expand to do
this. We also need proper locking. This isn't a trivial change but its
perfectly doable given a real world use case.

> According to a manual of setserial command, we could set RX interrupt
> trigger only for the Hayes ESP serial driver. However, current kernel
> does not support Hayes ESP serial[1]. I couldn't find this feature for
> current 8250/16X50 drivers.

It is long gone and was a set of ugly device specific hacks.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/