Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbaBRCUA (ORCPT ); Mon, 17 Feb 2014 21:20:00 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:60896 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752075AbaBRCT6 (ORCPT ); Mon, 17 Feb 2014 21:19:58 -0500 MIME-Version: 1.0 In-Reply-To: <1489022.1IbaesBAQQ@vostro.rjw.lan> References: <15ccc0609cb9ee3db0ad3a95b29bf69d11ea197c.1392375504.git.viresh.kumar@linaro.org> <5301CE86.9020105@linux.vnet.ibm.com> <1489022.1IbaesBAQQ@vostro.rjw.lan> Date: Tue, 18 Feb 2014 07:49:58 +0530 Message-ID: Subject: Re: [PATCH 1/2] cpufreq: Return error if ->get() failed in cpufreq_update_policy() From: Viresh Kumar To: "Rafael J. Wysocki" Cc: "Srivatsa S. Bhat" , Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Pierre Ossman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 February 2014 03:30, Rafael J. Wysocki wrote: > On Monday, February 17, 2014 02:25:34 PM Srivatsa S. Bhat wrote: >> Why go to no_policy when we can actually set things right? >> >> Anyway, I am not arguing against this strongly. I just wanted to share my >> thoughts, since this is the approach that made more sense to me. > > And I agree with that. In particular, since we're going to set the new > policy *anyway* at this point, we can adjust the current frequency just fine > in the process, can't we? Though I still feel that it wouldn't be the right thing to do as get() just can't return zero. Actually I was planning to place a WARN() over its return value of zero. Anyway, as two of the three are in favor of this we can get that in.. But how would that work? - What frequency should we call cpufreq_driver_target ? - Remember that it wouldn't do anything if policy->cur is same as new freq. - Also remember that drivers need special attention if new freq is > old freq or vice versa. As they will change voltage before or after change here. And because we actually don't know what frequency we are at currently, how will we decide that? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/