Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756173AbaBRRCm (ORCPT ); Tue, 18 Feb 2014 12:02:42 -0500 Received: from mail-qc0-f178.google.com ([209.85.216.178]:37260 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755787AbaBRRCj (ORCPT ); Tue, 18 Feb 2014 12:02:39 -0500 MIME-Version: 1.0 In-Reply-To: <20140218164614.GI21483@n2100.arm.linux.org.uk> References: <1391529538-21685-1-git-send-email-ulf.hansson@linaro.org> <1391529538-21685-4-git-send-email-ulf.hansson@linaro.org> <20140218160542.GH21483@n2100.arm.linux.org.uk> <20140218164614.GI21483@n2100.arm.linux.org.uk> Date: Tue, 18 Feb 2014 18:02:38 +0100 Message-ID: Subject: Re: [PATCH 03/17] mmc: mmci: Mask IRQs for all variants during runtime suspend From: Ulf Hansson To: Russell King - ARM Linux Cc: "linux-arm-kernel@lists.infradead.org" , Alessandro Rubini , Linus Walleij , Wolfram Sang , Chris Ball , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-spi@vger.kernel.org" , linux-mmc Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 February 2014 17:46, Russell King - ARM Linux wrote: > On Tue, Feb 18, 2014 at 05:36:52PM +0100, Ulf Hansson wrote: >> If we add SDIO irq support to mmci in future; parts of that >> implementation includes a re-route of DAT1 to a GPIO irq when entering >> runtime suspend state. The mmci HW will in runtime suspend state, not >> be responsible for handling irqs, which is the same as of today. > > Note that the "irq thread" in sdio_irq is scheduled for destruction - > it's buggy when the system is under high load and a driver claims a > SDIO irq. Sched people hate it too... We kind of realized that too, in the early days for ux500. At that point we converted it to a use a dedicated work queue, which improved the behaviour, don't remember the details why, but maybe I should collect the patches and send them out. :-) Finally we moved to use a separate GPIO irq as a dedicated SDIO irq line for our cw1200 wlan chip, mostly due to gain a bit of performance. That happened to simplified the mmci part as well, which was welcome. > > -- > FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation > in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. > Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/