Date: Tue, 18 Feb 2014 19:40:10 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Preeti Murthy <preeti.lkml@gmail.com>
cc: Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [GIT Pull] timer fixes for 3.14
In-Reply-To: <CAM4v1pNDbiC54Ot6J2Tpc9t4BgT3fY7jgZkb6Fem4OfedwvV-w@mail.gmail.com>
Message-ID: <alpine.DEB.2.02.1402181938140.4468@ionos.tec.linutronix.de>
References: <alpine.DEB.2.02.1402152005210.21991@ionos.tec.linutronix.de> <CAM4v1pNDbiC54Ot6J2Tpc9t4BgT3fY7jgZkb6Fem4OfedwvV-w@mail.gmail.com>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 18 Feb 2014, Preeti Murthy wrote:

> Hi Thomas,
> 
> With regard to the patch: "tick: Clear broadcast pending bit when
> switching to oneshot"
> isn't BROADCAST_EXIT called atleast after initializing the high
> resolution timers while
> handling the broadcast IPI and before re-entering idle? This should
> clear the cpu bit
> in the pending mask right?
> 
> idle()
> |__BROADCAST_ENTER
>     |__halt()
>       |__broadcast_ipi
>           |__init_highres()->clear oneshot mask
>               |__return from interrupt->BROADCAST_EXIT (clear pending mask)

Unfortunately not:

     if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_oneshot_mask)) {
     	  clear pending mask;
     }

>                    |__re-enter idle

Go figure :)
 
Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/