Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637AbaBRTac (ORCPT ); Tue, 18 Feb 2014 14:30:32 -0500 Received: from mail-ve0-f169.google.com ([209.85.128.169]:36812 "EHLO mail-ve0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbaBRTa3 convert rfc822-to-8bit (ORCPT ); Tue, 18 Feb 2014 14:30:29 -0500 MIME-Version: 1.0 In-Reply-To: <20140218190828.GA10376@kroah.com> References: <1392674322-9036-1-git-send-email-john.stultz@linaro.org> <1392674322-9036-13-git-send-email-john.stultz@linaro.org> <20140218190828.GA10376@kroah.com> Date: Tue, 18 Feb 2014 11:30:26 -0800 Message-ID: Subject: Re: [PATCH 12/14] staging: binder: Fix ABI for 64bit Android From: John Stultz To: Greg KH Cc: LKML , Serban Constantinescu , Colin Cross , =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= , Android Kernel Team Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 18, 2014 at 11:08 AM, Greg KH wrote: > On Mon, Feb 17, 2014 at 01:58:40PM -0800, John Stultz wrote: >> From: Serban Constantinescu >> >> This patch fixes the ABI for 64bit Android userspace. >> BC_REQUEST_DEATH_NOTIFICATION and BC_CLEAR_DEATH_NOTIFICATION claim >> to be using struct binder_ptr_cookie, but they are using a 32bit handle >> and a pointer. >> >> On 32bit systems the payload size is the same as the size of struct >> binder_ptr_cookie, however for 64bit systems this will differ. This >> patch adds struct binder_handle_cookie that fixes this issue for 64bit >> Android. >> >> Since there are no 64bit users of this interface that we know of this >> change should not affect any existing systems. > > But you are changing the ioctl structures here, what is that going to > cause with old programs? So I'd be glad for Serban or Arve to clarify, but my understanding (and as is described in the commit message) is that the assumption is there are no 64bit binder users at this point, and the ioctl structure changes are made such that existing 32bit applications are unaffected. >> Cc: Colin Cross >> Cc: Arve Hj?nnev?g >> Cc: Serban Constantinescu >> Cc: Android Kernel Team > > I am going to require Acks from someone on the Android team to accept > this, or any other 64bit binder patch, given all the back-and-forth that > has happened with the different patch sets here over the past year or > so. Certainly reasonable given the earlier back and forth. For extra context, these have been merged into the 3.10 AOSP by Arve: https://android-review.googlesource.com/#/c/79228/ thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/