Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbaBRWGQ (ORCPT ); Tue, 18 Feb 2014 17:06:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbaBRWGO (ORCPT ); Tue, 18 Feb 2014 17:06:14 -0500 Date: Tue, 18 Feb 2014 17:06:06 -0500 From: Dave Jones To: Linux Kernel Cc: Al Viro Subject: [PATCH] Set bounds on what /proc/self/make-it-fail accepts. Message-ID: <20140218220606.GA9712@redhat.com> Mail-Followup-To: Dave Jones , Linux Kernel , Al Viro MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org /proc/self/make-it-fail is a boolean, but accepts any number, including negative ones. Change variable to unsigned, and cap upper bound at 1. Signed-off-by: Dave Jones diff --git a/fs/proc/base.c b/fs/proc/base.c index 51507065263b..b926377c354f 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1207,7 +1207,7 @@ static ssize_t proc_fault_inject_read(struct file * file, char __user * buf, struct task_struct *task = get_proc_task(file_inode(file)); char buffer[PROC_NUMBUF]; size_t len; - int make_it_fail; + unsigned int make_it_fail; if (!task) return -ESRCH; @@ -1224,7 +1224,7 @@ static ssize_t proc_fault_inject_write(struct file * file, { struct task_struct *task; char buffer[PROC_NUMBUF], *end; - int make_it_fail; + unsigned int make_it_fail; if (!capable(CAP_SYS_RESOURCE)) return -EPERM; @@ -1236,6 +1236,9 @@ static ssize_t proc_fault_inject_write(struct file * file, make_it_fail = simple_strtol(strstrip(buffer), &end, 0); if (*end) return -EINVAL; + if (make_it_fail > 1) + return -EINVAL; + task = get_proc_task(file_inode(file)); if (!task) return -ESRCH; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/