DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=ENwI08vqjqtl5uG+z4Y/OX80LQiswZCVJEErARYR9liPgUdCMmFUiWY+mFiXC8tFRLkBPzvHN26Qh9joxa9OKZDaWQ0r5pwxS+eTVjzJa1u2YbY1+yzI5jU7+riEGTlCAQcUAsrNlW0T18FYrAqWg7mh644iEyivHsYQintbn5k=;
References: <1392540006-25972-1-git-send-email-chase.southwood@yahoo.com> <53020B92.6060805@mev.co.uk> <1392669907.92125.YahooMailNeo@web164001.mail.gq1.yahoo.com> <20140218105944.GM26722@mwanda>
Message-ID: <1392773159.94094.YahooMailNeo@web164004.mail.gq1.yahoo.com>
Date: Tue, 18 Feb 2014 17:25:59 -0800 (PST)
From: Chase Southwood <chase.southwood@yahoo.com>
Reply-To: Chase Southwood <chase.southwood@yahoo.com>
Subject: Re: [PATCH 1/4] Staging: comedi: addi-data: fix brace-related coding style issues in hwdrv_apci035.c
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20140218105944.GM26722@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org


>On Tuesday, February 18, 2014 5:00 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:

>>On Mon, Feb 17, 2014 at 12:45:07PM -0800, Chase Southwood wrote:
>>>On Monday, February 17, 2014 7:16 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
>>>>
>>>>On 2014-02-16 08:40, Chase Southwood wrote:
>>>> This patch for hwdrv_apci035 removes some unneeded braces, and moves some
>>>> improperly placed braces to the correct position, as found by checkpatch.
>>>> It also removes a commented out if-statement that I found whilst cleaning
>>>> braces that is identical to another un-commented if-statement directly
>>>> above it, so it is just added clutter and so we can delete it to clean up
>>>> further.
>>>>
>>>> Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
>>>> ---
>>>> So I decided to venture into addi-data today and found that most of the
>>>> files in there are very messy from a style standpoint.? This is the first
>>>> (of probably a few) patchsets to try and clean those files up a bit.? I
>>>> hope that this will be helpful!
>>>>
>>>Quite a few have been cleaned up extensively by Hartley, but they needed 
>>>more extensive changes than clean-ups due to them trying to handle 
>>>things differently to the normal comedi way of doing things.
>>
>>Oh, I see.? Makes perfect sense.? Well like I said, if cleaning them
>>up a bit will help make reworking them any easier or seems like useful
>>work, I'd be happy to continue making them a little easier on the
>>eyes!
>
>Ian acked your patch already...? If you want to clean these up then go
>for it.? There is no reason Hartley should have to do all the work.
>
>But consider doing more "extensive" cleanups.? Instead of just shifting
>the comments over in [patch 2/4] you could change the format to kernel
>style.? Newbies are too timid.? Look through the work that Hartley has
>done and try copy it.
>
>regards,
>dan carpenter

Dan,

I appreciate the feedback on my contributions.? I will try to do more extensive cleaning because I want to help out as best as I can.

Thanks,
Chase

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/