Date: Wed, 19 Feb 2014 10:12:48 +0800
From: Shawn Guo <shawn.guo@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
CC: Fabio Estevam <fabio.estevam@freescale.com>,
        Mark Brown <broonie@kernel.org>, <festevam@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pfuze100-regulator: Revert "regulator: pfuze100: Use
 of_get_child_by_name"
Message-ID: <20140219021246.GK15716@S2101-09.ap.freescale.net>
References: <1392738636-29877-1-git-send-email-fabio.estevam@freescale.com>
 <CAK9yfHykaoap7Dz+fsZgReRoXW_GsKvmZX7RDGqknd1_o3R50g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAK9yfHykaoap7Dz+fsZgReRoXW_GsKvmZX7RDGqknd1_o3R50g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote:
> On 18 February 2014 21:20, Fabio Estevam <fabio.estevam@freescale.com> wrote:
> > Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> > the following probe failure:
> >
> > pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> > pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> > pfuze100-regulator 1-0008: regulators node not found
> > pfuze100-regulator: probe of 1-0008 failed with error -22
> >
> > Revert the offending commit so that we can probe the regulator successfully.
> 
> I wonder what is different in this case from the ones that I already
> have working
> that is causing this to fail. Can you please tell me which dts file
> you have used
> so that I can see if the way the node is defined is anything different.

When you change to use of_get_child_by_name(), you should change 'np' to
point to dev->of_node too.

Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/