Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbaBSCW2 (ORCPT ); Tue, 18 Feb 2014 21:22:28 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:44720 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbaBSCW0 (ORCPT ); Tue, 18 Feb 2014 21:22:26 -0500 Date: Tue, 18 Feb 2014 18:22:24 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: riel@redhat.com cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, peterz@infradead.org, chegu_vinod@hp.com, aarcange@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH -mm 2/3] mm,numa: reorganize change_pmd_range In-Reply-To: <1392761566-24834-3-git-send-email-riel@redhat.com> Message-ID: References: <1392761566-24834-1-git-send-email-riel@redhat.com> <1392761566-24834-3-git-send-email-riel@redhat.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Feb 2014, riel@redhat.com wrote: > From: Rik van Riel > > Reorganize the order of ifs in change_pmd_range a little, in > preparation for the next patch. > > Signed-off-by: Rik van Riel > Cc: Peter Zijlstra > Cc: Andrea Arcangeli > Reported-by: Xing Gang > Tested-by: Chegu Vinod Acked-by: David Rientjes > --- > mm/mprotect.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 769a67a..6006c05 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -118,6 +118,8 @@ static inline unsigned long change_pmd_range(struct vm_area_struct *vma, > unsigned long this_pages; > > next = pmd_addr_end(addr, end); > + if (!pmd_trans_huge(*pmd) && pmd_none_or_clear_bad(pmd)) > + continue; > if (pmd_trans_huge(*pmd)) { > if (next - addr != HPAGE_PMD_SIZE) > split_huge_page_pmd(vma, addr, pmd); Extra tab there, though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/