Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbaBSDM1 (ORCPT ); Tue, 18 Feb 2014 22:12:27 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35297 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbaBSDMY (ORCPT ); Tue, 18 Feb 2014 22:12:24 -0500 MIME-Version: 1.0 In-Reply-To: References: <1392722606-965-1-git-send-email-sj38.park@gmail.com> <20140218170753.GB32227@kroah.com> From: SeongJae Park Date: Wed, 19 Feb 2014 12:11:53 +0900 Message-ID: Subject: Re: [PATCH 1/2] staging: android: binder: remove unnecessary comment To: Sachin Kamat Cc: Greg KH , "devel@driverdev.osuosl.org" , Brian Swetland , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2014 at 12:04 PM, Sachin Kamat wrote: > On 19 February 2014 05:58, SeongJae Park wrote: >> On Wed, Feb 19, 2014 at 2:07 AM, Greg KH wrote: >>> On Tue, Feb 18, 2014 at 08:23:25PM +0900, SeongJae Park wrote: >>>> Signed-off-by: SeongJae Park >>>> --- >>>> drivers/staging/android/binder.c | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c >>>> index eaec1da..b23cbc9 100644 >>>> --- a/drivers/staging/android/binder.c >>>> +++ b/drivers/staging/android/binder.c >>>> @@ -2553,8 +2553,6 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) >>>> unsigned int size = _IOC_SIZE(cmd); >>>> void __user *ubuf = (void __user *)arg; >>>> >>>> - /*pr_info("binder_ioctl: %d:%d %x %lx\n", proc->pid, current->pid, cmd, arg);*/ >>> >>> It's useful for debugging, I'll leave it as-is, sorry. > > Or just convert pr_info to pr_debug and leave uncommented? Sounds much better. Thank you for suggestion. I will send patch with your recommend again soon. > > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/