Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S264946AbSKESKD>; Tue, 5 Nov 2002 13:10:03 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S264875AbSKESJc>; Tue, 5 Nov 2002 13:09:32 -0500
Received: from pc1-cwma1-5-cust42.swa.cable.ntl.com ([80.5.120.42]:43157 "EHLO
	irongate.swansea.linux.org.uk") by vger.kernel.org with ESMTP
	id <S264946AbSKESJP>; Tue, 5 Nov 2002 13:09:15 -0500
Subject: Re: [PATCH] Re: time() glitch on 2.4.18: solved
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jim Paris <jim@jtan.com>
Cc: Willy Tarreau <willy@w.ods.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20021105130222.A6245@neurosis.mit.edu>
References: <20021102013704.A24684@neurosis.mit.edu>
	<20021103143216.A27147@neurosis.mit.edu>
	<1036355418.30679.28.camel@irongate.swansea.linux.org.uk>
	<20021105113020.A5210@neurosis.mit.edu>
	<20021105171035.GB879@alpha.home.local>
	<1036520191.5012.109.camel@irongate.swansea.linux.org.uk> 
	<20021105130222.A6245@neurosis.mit.edu>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Ximian Evolution 1.0.8 (1.0.8-10) 
Date: 05 Nov 2002 18:37:57 +0000
Message-Id: <1036521477.4827.118.camel@irongate.swansea.linux.org.uk>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 797
Lines: 22

On Tue, 2002-11-05 at 18:02, Jim Paris wrote:
> > > > +		if (count > LATCH) {
> > > 
> > > may be (count >= LATCH) would be even better ?
> > 
> > Some PIT clones seem to hold the LATCH value momentarily judging by
> > other things that were triggered wrongly by >=
> 
> If so, then that's a separate problem: the later code
> 
> 	count = ((LATCH-1) - count) * TICK_SIZE;
> 	delay_at_last_interrupt = (count + LATCH/2) / LATCH;
> 

It might be interesting to catch that case with a printk too and put
both in 2.5 and see what comes out in the wash yes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/