Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755110AbaBSTTf (ORCPT ); Wed, 19 Feb 2014 14:19:35 -0500 Received: from smtp.citrix.com ([66.165.176.89]:39004 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754704AbaBSTTe (ORCPT ); Wed, 19 Feb 2014 14:19:34 -0500 X-IronPort-AV: E=Sophos;i="4.97,507,1389744000"; d="scan'208";a="104018867" Message-ID: <530503C3.4050307@citrix.com> Date: Wed, 19 Feb 2014 19:19:31 +0000 From: Zoltan Kiss User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ian Campbell CC: , , , , Subject: Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions References: <1390253069-25507-1-git-send-email-zoltan.kiss@citrix.com> <1390253069-25507-2-git-send-email-zoltan.kiss@citrix.com> <1392744286.23084.52.camel@kazak.uk.xensource.com> In-Reply-To: <1392744286.23084.52.camel@kazak.uk.xensource.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.2.133] X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/14 17:24, Ian Campbell wrote: > On Mon, 2014-01-20 at 21:24 +0000, Zoltan Kiss wrote: >> >> + spinlock_t dealloc_lock; >> + spinlock_t response_lock; > > Please add comments to both of these describing what bits of the > datastructure they are locking. > > You might find it is clearer to group the locks and the things they > protect together rather than grouping the locks together. Ok, I'll give more description here. The response_lock is actually quite relevant to be here, but indeed that's not obvious, I'll explain that as well. Zoli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/