Date: Wed, 19 Feb 2014 20:49:50 +0800
From: Fabian Frederick <fabf@skynet.be>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org,
        rdunlap <rdunlap@infradead.org>, gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/1] sys_sysfs: Add CONFIG_SYSFS_SYSCALL
Message-Id: <20140219204950.f88f409e2bb5a590b1183724@skynet.be>
In-Reply-To: <20140213144319.3b6f4de46b3a067c3ea53ad3@linux-foundation.org>
References: <20140213220942.ff2ebaeff3876b7136fa4b10@skynet.be>
	<20140213223141.GA1232@redhat.com>
	<20140213144319.3b6f4de46b3a067c3ea53ad3@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 13 Feb 2014 14:43:19 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Thu, 13 Feb 2014 17:31:41 -0500 Dave Jones <davej@redhat.com> wrote:
> 
> > On Thu, Feb 13, 2014 at 10:09:42PM +0800, Fabian Frederick wrote:
> >  > sys_sysfs is an obsolete system call no longer supported by libc ...
> >  > -This patch adds a default CONFIG_SYSFS_SYSCALL=y
> >  > -Option can be turned off in expert mode.
> >  > -cond_syscall added to kernel/sys_ni.c
> >  > 
> >  > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> >  > ---
> >  >  fs/filesystems.c |  2 ++
> >  >  init/Kconfig     | 10 ++++++++++
> >  >  kernel/sys_ni.c  |  1 +
> >  >  3 files changed, 13 insertions(+)
> > 
> > did anyone ever ship userspace that actually used that syscall ?
> > Some ancient version of udev that probably doesn't work on a modern kernel anyway maybe ?
> > 
> > I wonder if it's something we can make -ENOSYS unconditionally at some point,
> > and remove all that code entirely.
> 
> Perhaps we could make it `default n' now and see if we receive nastygrams?

As it seems very old, maybe we wouldn't have any trouble for users in linux-next but it could break something when going in stable (?).Having that patch with functions enabled by default will give us time to test it and have a pointer to it to remove later...

Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/