Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbaBSW4P (ORCPT ); Wed, 19 Feb 2014 17:56:15 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:54460 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbaBSW4O (ORCPT ); Wed, 19 Feb 2014 17:56:14 -0500 Message-ID: <1392850749.22195.1.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH] target_core_alua: silence GCC warning From: "Nicholas A. Bellinger" To: Paul Bolle Cc: Geert Uytterhoeven , scsi , target-devel , "linux-kernel@vger.kernel.org" Date: Wed, 19 Feb 2014 14:59:09 -0800 In-Reply-To: <1392804347.27558.20.camel@x220> References: <1392714172-2712-1-git-send-email-geert@linux-m68k.org> <1392803546.27558.16.camel@x220> <1392804347.27558.20.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-02-19 at 11:05 +0100, Paul Bolle wrote: > On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote: > > On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle wrote: > > > - ret = core_alua_state_nonoptimized(cmd, cdb, > > > - nonop_delay_msecs, &alua_ascq); > > > + core_alua_state_nonoptimized(cmd, cdb, nonop_delay_msecs); > > > > I suggest making core_alua_state_nonoptimized() return void, too. > > Currently it always returns zero. > > Good catch. Not sure how I missed that, since I deliberately ignore its > return value here. > > I'll wait with sending a v2 until after Nicholas or the other target > developers have given their feedback. > > Hi Paul, The patch is fine with me.. Feel free to post a -v2. Thanks, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/