Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbaBTKNQ (ORCPT ); Thu, 20 Feb 2014 05:13:16 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:37504 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752086AbaBTKNN (ORCPT ); Thu, 20 Feb 2014 05:13:13 -0500 X-IronPort-AV: E=Sophos;i="4.97,511,1389744000"; d="scan'208";a="102564414" Date: Thu, 20 Feb 2014 10:13:11 +0000 From: Wei Liu To: Zoltan Kiss CC: Ian Campbell , , , , , Subject: Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions Message-ID: <20140220101311.GA24574@zion.uk.xensource.com> References: <1390253069-25507-1-git-send-email-zoltan.kiss@citrix.com> <1390253069-25507-2-git-send-email-zoltan.kiss@citrix.com> <1392743214.23084.38.camel@kazak.uk.xensource.com> <5303C44D.4070500@citrix.com> <1392804319.23084.109.camel@kazak.uk.xensource.com> <53050BF5.1060009@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <53050BF5.1060009@citrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2014 at 07:54:29PM +0000, Zoltan Kiss wrote: > On 19/02/14 10:05, Ian Campbell wrote: > >On Tue, 2014-02-18 at 20:36 +0000, Zoltan Kiss wrote: > >>On 18/02/14 17:06, Ian Campbell wrote: > >>>On Mon, 2014-01-20 at 21:24 +0000, Zoltan Kiss wrote: > >>>>This patch contains the new definitions necessary for grant mapping. > >>> > >>>Is this just adding a bunch of (currently) unused functions? That's a > >>>slightly odd way to structure a series. They don't seem to be "generic > >>>helpers" or anything so it would be more normal to introduce these as > >>>they get used -- it's a bit hard to review them out of context. > >>I've created two patches because they are quite huge even now, > >>separately. Together they would be a ~500 line change. That was the best > >>I could figure out keeping in mind that bisect should work. But as I > >>wrote in the first email, I welcome other suggestions. If you and Wei > >>prefer this two patch in one big one, I merge them in the next version. > > > >I suppose it is hard to split a change like this up in a sensible way, > >but it is rather hard to review something which is split in two parts > >sensibly. > > > >If the combined patch too large to fit on the lists? > Well, it's ca. 30 kb, ~500 lines changed. I guess it's possible. > It's up to you and Wei, if you would like them to be merged, I can > do that. > As I said before, my bottom line is "don't break bisection". Do whatever you want to. :-) Wei. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/