Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbaBTKpZ (ORCPT ); Thu, 20 Feb 2014 05:45:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbaBTKpY (ORCPT ); Thu, 20 Feb 2014 05:45:24 -0500 Date: Thu, 20 Feb 2014 11:44:40 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , David Ahern , Andi Kleen Subject: Re: [PATCH 4/8] perf top: Add --percentage option Message-ID: <20140220104440.GB11018@krava.brq.redhat.com> References: <1392000446-14744-1-git-send-email-namhyung@kernel.org> <1392000446-14744-5-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392000446-14744-5-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 11:47:21AM +0900, Namhyung Kim wrote: > The --percentage option is for controlling overhead percentage > displayed. It can only receive either of "relative" or "absolute". > > For more information, please see previous commit same thing done to > "perf report". > > Signed-off-by: Namhyung Kim > --- SNIP > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > index ed99ec4a309f..a516e0389c5e 100644 > --- a/tools/perf/builtin-top.c > +++ b/tools/perf/builtin-top.c > @@ -1011,6 +1011,20 @@ parse_percent_limit(const struct option *opt, const char *arg, > return 0; > } > > +static int > +parse_percentage(const struct option *opt __maybe_unused, const char *arg, > + int unset __maybe_unused) > +{ > + if (!strcmp(arg, "relative")) > + symbol_conf.filter_relative = true; > + else if (!strcmp(arg, "absolute")) > + symbol_conf.filter_relative = false; > + else > + return -1; > + > + return 0; > +} please make one of parse_percentage functions public and share it among report/top/diff commands jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/