Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbaBTVSQ (ORCPT ); Thu, 20 Feb 2014 16:18:16 -0500 Received: from www.linutronix.de ([62.245.132.108]:34615 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbaBTVSP (ORCPT ); Thu, 20 Feb 2014 16:18:15 -0500 Date: Thu, 20 Feb 2014 22:18:19 +0100 (CET) From: Thomas Gleixner To: John Stultz cc: Alexey Perevalov , linux-kernel@vger.kernel.org, anton@nomsg.org, kyungmin.park@samsung.com, cw00.choi@samsung.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 2/6] hrtimer: Add support for deferrable timer into the hrtimer In-Reply-To: <53064E4A.8030105@linaro.org> Message-ID: References: <1392885633-7787-1-git-send-email-a.perevalov@samsung.com> <1392885633-7787-3-git-send-email-a.perevalov@samsung.com> <53064E4A.8030105@linaro.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Feb 2014, John Stultz wrote: > On 02/20/2014 12:40 AM, Alexey Perevalov wrote: > > diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h > > index e75e1b6..bb8dc60 100644 > > --- a/include/uapi/linux/time.h > > +++ b/include/uapi/linux/time.h > > @@ -56,6 +56,9 @@ struct itimerval { > > #define CLOCK_BOOTTIME_ALARM 9 > > #define CLOCK_SGI_CYCLE 10 /* Hardware specific */ > > #define CLOCK_TAI 11 > > +#define CLOCK_REALTIME_DEFERRABLE 12 > > +#define CLOCK_MONOTONIC_DEFERRABLE 13 > > +#define CLOCK_BOOTTIME_DEFERRABLE 14 > > Adding the deferrable HRTIMER bases above is right, but I don't think we > agreed on adding the _DEFERRABLE clockids. > > I'd instead prefer you use add a new TIMER_DEFERABLE flags argument, and > use the combination of the clockid + flag to decide which HRTIMER base > is used. And how does that work with anything else than timerfd? If we add deferrable posix clocks then we add them for the other interfaces which take a clockid as well. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/