Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbaBTWqG (ORCPT ); Thu, 20 Feb 2014 17:46:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbaBTWqF (ORCPT ); Thu, 20 Feb 2014 17:46:05 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1392929071-16555-8-git-send-email-tj@kernel.org> References: <1392929071-16555-8-git-send-email-tj@kernel.org> <1392929071-16555-1-git-send-email-tj@kernel.org> To: Tejun Heo Cc: dhowells@redhat.com, laijs@cn.fujitsu.com, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org Subject: Re: [PATCH 7/9] afs: don't use PREPARE_WORK Date: Thu, 20 Feb 2014 22:00:05 +0000 Message-ID: <32161.1392933605@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tejun Heo wrote: > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > and a nasty surprise in terms of reentrancy guarantee as workqueue > considers work items to be different if they don't have the same work > function. Why so? Isn't the work item address sufficient to distinguish them? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/