Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbaBUFf0 (ORCPT ); Fri, 21 Feb 2014 00:35:26 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:32994 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbaBUFfX (ORCPT ); Fri, 21 Feb 2014 00:35:23 -0500 Message-ID: <5306E599.7020605@wwwdotorg.org> Date: Thu, 20 Feb 2014 22:35:21 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Chen-Yu Tsai CC: Heikki Krogerus , Johannes Berg , "David S. Miller" , Rhyland Klein , linux-wireless , netdev , linux-kernel , Arnd Bergmann , Linus Walleij , Alexandre Courbot Subject: Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names References: <1392900697-27577-1-git-send-email-heikki.krogerus@linux.intel.com> <1392900697-27577-3-git-send-email-heikki.krogerus@linux.intel.com> <53062F97.3050407@wwwdotorg.org> In-Reply-To: X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/20/2014 06:55 PM, Chen-Yu Tsai wrote: > Hi, > > On Fri, Feb 21, 2014 at 12:38 AM, Stephen Warren wrote: >> On 02/20/2014 05:51 AM, Heikki Krogerus wrote: >>> There is no use for them in this driver. This will fix a >>> static checker warning.. >> >> Didn't you remove the use: >> >> - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0); >> + gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0); >> >> doesn't that parameter get put into the sysfs GPIO debug file, so people >> can see which GPIOs are used for what? > > That's correct. However using con_id to pass this results in different > behavior across DT and ACPI. A better way is to export the labeling > function so consumers can set meaningful labels themselves. But this code is the consumer of those GPIOs. IF the parameter to devm_gpiod_get_index() isn't intended to be used, why does it exist? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/