Date: Fri, 21 Feb 2014 11:19:33 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: =?utf-8?B?6buD5riF6ZqG?= <ching2048@areca.com.tw>
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
        Tomas Henzl <thenzl@redhat.com>
Subject: Re: [PATCH v1.3 10/11] arcmsr: Fixed coding style errors and white
 space change
Message-ID: <20140221081933.GH26776@mwanda>
References: <CAKiknE-FJg9y7CTMbvow277mr=H+oKkBLjDc1qDYjhHtpfBdZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKiknE-FJg9y7CTMbvow277mr=H+oKkBLjDc1qDYjhHtpfBdZA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Feb 21, 2014 at 12:35:58PM +0800, 黃清隆 wrote:
> From: Ching <ching2048@areca.com.tw>
> 
> Fixed coding style errors and white space change.
> 

This doesn't *just* do that.  It also has code changes.

> -static void arcmsr_hbaC_flush_cache(struct AdapterControlBlock *pACB)
> +static void
> +arcmsr_hbaC_flush_cache(struct AdapterControlBlock *pACB)
>  {
>         struct MessageUnit_C __iomem *reg = pACB->pmuC;
> -       int retry_count = 30;/* enlarge wait flush adapter cache time:
> 10 minute */
> +       int retry_count = 6;
> +
>         writel(ARCMSR_INBOUND_MESG0_FLUSH_CACHE, &reg->inbound_msgaddr0);
>         writel(ARCMSR_HBCMU_DRV2IOP_MESSAGE_CMD_DONE, &reg->inbound_doorbell);
> +       readl(&reg->inbound_doorbell);
> +       readl(&reg->inbound_msgaddr0);


We also change the printed driver string and there are other code
changes as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/