Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933198AbaBUNxU (ORCPT ); Fri, 21 Feb 2014 08:53:20 -0500 Received: from mail-oa0-f44.google.com ([209.85.219.44]:64729 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932283AbaBUNxQ (ORCPT ); Fri, 21 Feb 2014 08:53:16 -0500 MIME-Version: 1.0 In-Reply-To: <1392984758-10127-1-git-send-email-k.kozlowski@samsung.com> References: <1392984758-10127-1-git-send-email-k.kozlowski@samsung.com> Date: Fri, 21 Feb 2014 19:23:14 +0530 Message-ID: Subject: Re: [PATCH v2] regulator: max14577: Fix invalid return value on DT parse success From: Sachin Kamat To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 February 2014 17:42, Krzysztof Kozlowski wrote: > This fixes bug introduced in 667a6b7a (regulator: max14577: Add missing > of_node_put). The DTS parsing function returned number of matched > regulators as success status which then was compared against 0 in probe. > > Result was a probe fail after successful parsing the DTS: > max14577-regulator: probe of max14577-regulator failed with error 2 > > Signed-off-by: Krzysztof Kozlowski > Cc: Sachin Kamat Looks good. Reviewed-by: Sachin Kamat -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/