Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755841AbaBUO4i (ORCPT ); Fri, 21 Feb 2014 09:56:38 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:61947 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755062AbaBUO4g (ORCPT ); Fri, 21 Feb 2014 09:56:36 -0500 MIME-Version: 1.0 In-Reply-To: <5307683C.50209@suse.de> References: <20140220235118.191692546@linuxfoundation.org> <20140220235119.236520201@linuxfoundation.org> <5307683C.50209@suse.de> Date: Fri, 21 Feb 2014 09:56:35 -0500 X-Google-Sender-Auth: 5TEOLl3_p4FwCF7kfrQ7375bK8Y Message-ID: Subject: Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute From: Josh Boyer To: Hannes Reinecke Cc: Greg Kroah-Hartman , "Linux-Kernel@Vger. Kernel. Org" , "stable@vger.kernel.org" , Lennart Poettering , Kay Sievers , Jiri Slaby , David Herrmann , Werner Fink , Ray Strode Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2014 at 9:52 AM, Hannes Reinecke wrote: > On 02/21/2014 03:48 PM, Josh Boyer wrote: >> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman >> wrote: >>> 3.13-stable review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Hannes Reinecke >>> >>> commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream. >>> >>> The 'active' sysfs attribute should refer to the currently active tty >>> devices the console is running on, not the currently active console. >>> >>> The console structure doesn't refer to any device in sysfs, only the tty >>> the console is running on has. So we need to print out the tty names in >>> 'active', not the console names. >>> >>> This resolves an issue on s390 platforms in determining the correct >>> console device to use. >> >> Just to be double sure this is seen, Ray points out that it breaks >> current plymouth because the heuristic changed. Hold off on this one? >> > Without this patch systemd won't present a login console for s390. > I'd prefer fixing plymouth. Sure. Except fixing plymouth is easy to do, but not easy to actually get deployed on all of the old userspace. So if someone runs a 3.14 kernel on any distro that doesn't have a fixed plymouth, it's broken. By including this patch, you're basically trading one broken userspace component for another. Is there some other way this could be fixed in-kernel that would allow both to work? josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/