Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755924AbaBUO4w (ORCPT ); Fri, 21 Feb 2014 09:56:52 -0500 Received: from mailout32.mail01.mtsvc.net ([216.70.64.70]:51750 "EHLO n23.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755667AbaBUO4t (ORCPT ); Fri, 21 Feb 2014 09:56:49 -0500 Message-ID: <5307692B.4070005@hurleysoftware.com> Date: Fri, 21 Feb 2014 09:56:43 -0500 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Hannes Reinecke , Josh Boyer , Greg Kroah-Hartman CC: "Linux-Kernel@Vger. Kernel. Org" , "stable@vger.kernel.org" , Lennart Poettering , Kay Sievers , Jiri Slaby , David Herrmann , Werner Fink , Ray Strode Subject: Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute References: <20140220235118.191692546@linuxfoundation.org> <20140220235119.236520201@linuxfoundation.org> <5307683C.50209@suse.de> In-Reply-To: <5307683C.50209@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-User: 990527 peter@hurleysoftware.com X-MT-ID: 8FA290C2A27252AACF65DBC4A42F3CE3735FB2A4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2014 09:52 AM, Hannes Reinecke wrote: > On 02/21/2014 03:48 PM, Josh Boyer wrote: >> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman >> wrote: >>> 3.13-stable review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Hannes Reinecke >>> >>> commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream. >>> >>> The 'active' sysfs attribute should refer to the currently active tty >>> devices the console is running on, not the currently active console. >>> >>> The console structure doesn't refer to any device in sysfs, only the tty >>> the console is running on has. So we need to print out the tty names in >>> 'active', not the console names. >>> >>> This resolves an issue on s390 platforms in determining the correct >>> console device to use. >> >> Just to be double sure this is seen, Ray points out that it breaks >> current plymouth because the heuristic changed. Hold off on this one? >> > Without this patch systemd won't present a login console for s390. > I'd prefer fixing plymouth. Not an option. As I said before, the old interface should be left alone and forked to present a new interface that systemd can use to get what it expects. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/