Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753543AbaBUUJY (ORCPT ); Fri, 21 Feb 2014 15:09:24 -0500 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36542 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbaBUUJW (ORCPT ); Fri, 21 Feb 2014 15:09:22 -0500 MIME-Version: 1.0 In-Reply-To: References: <1392986945-9693-1-git-send-email-luis.henriques@canonical.com> <1392986945-9693-86-git-send-email-luis.henriques@canonical.com> Date: Fri, 21 Feb 2014 21:09:22 +0100 Message-ID: Subject: Re: [PATCH 3.11 085/121] tty: Set correct tty name in 'active' sysfs attribute From: David Herrmann To: Josh Boyer Cc: Ray Strode , Luis Henriques , "Linux-Kernel@Vger. Kernel. Org" , "stable@vger.kernel.org" , Ubuntu kernel team , Lennart Poettering , Kay Sievers , Jiri Slaby , Werner Fink , Hannes Reinecke , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Fri, Feb 21, 2014 at 3:46 PM, Josh Boyer wrote: > On Fri, Feb 21, 2014 at 9:37 AM, Ray Strode wrote: >> Hi, >> >> This broke plymouth, i think. Plymouth used the herustic: >> "/sys/class/tty/console/active contains something other than tty0" to >> mean "probably has serial consoles, force verbose messages instead of >> a splash screen". Now on a normal system it contains tty1. >> >> I pushed a commit to plymouth that gets it working again, but it could >> cause compatiblity concerns if new kernels are pushed to old releases. > > Hm. Breaking userspace is probably a bad thing here. > > Greg, you have this queued for 3.13.5 at the moment. Maybe we should > hold off on this one until this discussion is sorted out? Looks like a broken patch, not a broken idea. So you should probably hold off on this one till we figure it out. See Kay's comment on Greg's series for more. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/