Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755357AbaBUUtT (ORCPT ); Fri, 21 Feb 2014 15:49:19 -0500 Received: from mail-yh0-f52.google.com ([209.85.213.52]:55001 "EHLO mail-yh0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbaBUUtR (ORCPT ); Fri, 21 Feb 2014 15:49:17 -0500 Date: Fri, 21 Feb 2014 12:49:07 -0800 From: Brian Norris To: Laurent Pinchart , Geert Uytterhoeven Cc: Geert Uytterhoeven , linux-mtd@lists.infradead.org, David Woodhouse , linux-kernel@vger.kernel.org, Richard Weinberger Subject: Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA Message-ID: <20140221204907.GA18743@ld-irv-0074> References: <1393012474-22399-1-git-send-email-geert@linux-m68k.org> <8022927.N4UoME29Ho@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8022927.N4UoME29Ho@avalon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Fri, Feb 21, 2014 at 09:27:27PM +0100, Laurent Pinchart wrote: > On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote: > > If NO_DMA=y: > > > > drivers/built-in.o: In function `flctl_dma_fifo0_transfer': > > sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single' > > sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single' > > > > Signed-off-by: Geert Uytterhoeven > > Acked-by: Laurent Pinchart > > > --- > > drivers/mtd/nand/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > > index 90ff447bf043..e7786913280a 100644 > > --- a/drivers/mtd/nand/Kconfig > > +++ b/drivers/mtd/nand/Kconfig > > @@ -458,6 +458,7 @@ config MTD_NAND_MXC > > > > config MTD_NAND_SH_FLCTL > > tristate "Support for NAND on Renesas SuperH FLCTL" > > + depends on HAS_DMA > > depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST > > help > > Several Renesas SuperH CPU has FLCTL. This option enables support It looks like Richard beat you to this. I have a similar patch queued up in l2-mtd.git: commit 4c8a074b3abab5a5d77c9a19f2fa5fb9d50f9908 Author: Richard Weinberger Date: Fri Jan 31 13:39:07 2014 +0100 mtd: nand: flctl: Add dependency on HAS_IOMEM and HAS_DMA Thanks, Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/