Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603AbaBUVSt (ORCPT ); Fri, 21 Feb 2014 16:18:49 -0500 Received: from terminus.zytor.com ([198.137.202.10]:59097 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbaBUVSq (ORCPT ); Fri, 21 Feb 2014 16:18:46 -0500 Message-ID: <5307C2A2.5010006@zytor.com> Date: Fri, 21 Feb 2014 13:18:26 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Andrew Morton , Kees Cook CC: LKML , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Jianguo Wu , Andy Honig , David Rientjes Subject: Re: [PATCH] x86, kaslr: randomize module base load address References: <20140221202110.GA29885@www.outflux.net> <20140221123658.5752f75eea6506d17bfa313b@linux-foundation.org> <20140221131531.2db80023c59895a930cf374f@linux-foundation.org> In-Reply-To: <20140221131531.2db80023c59895a930cf374f@linux-foundation.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2014 01:15 PM, Andrew Morton wrote: >> >> I've been slapped down for adding more config options in the past, and >> I think it's unlikely that people using CONFIG_RANDOMIZE_BASE won't >> want the modules base randomized too. I think this is a safe default, >> but if you see it as a requirement, I can change it. > > I think there were issues with some embedded systems where it's > hard/impossible to provide/alter boot parameters. > We now allow kernel parameters to be compiled into the kernel image for that reason. > > btw, would it be better to make each module have its own offset rather > than using the same offset for all of them? That could cause problems > with vmap space fragmentation I guess. > ... but it would improve the amount of entropy. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/