Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755577AbaBUV4H (ORCPT ); Fri, 21 Feb 2014 16:56:07 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:37099 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbaBUV4F convert rfc822-to-8bit (ORCPT ); Fri, 21 Feb 2014 16:56:05 -0500 MIME-Version: 1.0 In-Reply-To: <5307C553.9040504@linaro.org> References: <1393015414-12499-1-git-send-email-john.stultz@linaro.org> <1393015414-12499-3-git-send-email-john.stultz@linaro.org> <5307C553.9040504@linaro.org> Date: Fri, 21 Feb 2014 13:56:04 -0800 Message-ID: Subject: Re: [PATCH 2/3] staging: binder: Support concurrent 32 bit and 64 bit processes. From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: John Stultz Cc: LKML , Greg KH , Colin Cross , Serban Constantinescu , Android Kernel Team Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2014 at 1:29 PM, John Stultz wrote: > On 02/21/2014 12:59 PM, Arve Hj?nnev?g wrote: >> On Fri, Feb 21, 2014 at 12:43 PM, John Stultz wrote: >>> From: Arve Hj?nnev?g >>> >>> For 64bit systems we want to use the same binder interface for 32bit and >>> 64bit processes. Thus the size and the layout of the structures passed >>> between the kernel and the userspace has to be the same for both 32 and >>> 64bit processes. >>> >>> This change replaces all the uses of void* and size_t with >>> binder_uintptr_t and binder_size_t. These are then typedefed to specific >>> sizes depending on the use of the interface, as follows: >>> * __u32 - on legacy 32bit only userspace >>> * __u64 - on mixed 32/64bit userspace where all processes use the same >>> interface. >>> >>> This change also increments the BINDER_CURRENT_PROTOCOL_VERSION to 8 and >>> hooks the compat_ioctl entry for the mixed 32/64bit Android userspace. >>> >> It only increments the version to 8 if the old 32 bit interface is not selected. >> >>> This patch also provides a CONFIG_ANDROID_BINDER_IPC_32BIT option for >>> compatability, which if set which enables the old protocol on 32 bit >>> systems. > > Ok. I thought that point was covered by the detail on > CONFIG_ANDROID_BINDER_IPC_32BIT, but maybe its not explicit enough. > > Would you be ok with: > > This change also increments the BINDER_CURRENT_PROTOCOL_VERSION to 8 and > hooks the compat_ioctl entry for the mixed 32/64bit Android userspace. > > This patch also provides a CONFIG_ANDROID_BINDER_IPC_32BIT option for > compatability, which if set which enables the old protocol, setting > BINDER_CURRENT_PROTOCOL_VERSION to 7, on 32 bit systems. > > ? > Yes, but replacing "This change" with "Selecting the 64 bit interface" would also work. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/