Date: Mon, 24 Feb 2014 13:19:02 +0000
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
        jacob.jun.pan@intel.com
Subject: Re: [PATCH RESEND] x86: iosf_mbi: Provide dummy functions if
 CONFIG_IOSF_MBI not set
Message-ID: <20140224131902.30983051@alan.etchedpixels.co.uk>
In-Reply-To: <1393117352-23717-1-git-send-email-david.e.box@linux.intel.com>
References: <1392248063-16389-1-git-send-email-david.e.box@linux.intel.com>
	<1393117352-23717-1-git-send-email-david.e.box@linux.intel.com>
Organization: Intel Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sat, 22 Feb 2014 17:02:32 -0800
"David E. Box" <david.e.box@linux.intel.com> wrote:

> From: "David E. Box" <david.e.box@linux.intel.com>
> 
> Add iosf_mbi_available function for loadable modules.
> Add dummy functions to prevent symbol lookup errors on loadable modules.
> Clarify that the write opcode is to be used for iosf_mbi_modify().
> Changes Kconfig for IOSF_MBI to default built-in.

Other than _available I would have expected all the others to resolve to
returning an error or doing a WARN() in the not compiled in case.

If someone is dumb enough to miss the checks we want the kernel to spew
forth copious announcements of the fact, not silently do nothing.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/