MIME-Version: 1.0
In-Reply-To: <1393259343-825-1-git-send-email-mathias.nyman@linux.intel.com>
References: <1393259343-825-1-git-send-email-mathias.nyman@linux.intel.com>
Date: Mon, 24 Feb 2014 08:47:09 -0800
Message-ID: <CAPcyv4gkdC=fM5-qURK5R=_BmTBACchtFxvYE_WHtZqqMukFJA@mail.gmail.com>
Subject: Re: [RFC PATCH v2] xhci: Prevent runtime pm from autosuspending
 during initialization
From: Dan Williams <dan.j.williams@intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: USB list <linux-usb@vger.kernel.org>,
        Sarah Sharp <sarah.a.sharp@linux.intel.com>,
        david.a.cohen@linux.intel.com,
        Jianqiang Tang <jianqiang.tang@intel.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org

On Mon, Feb 24, 2014 at 8:29 AM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
> xHCI driver has its own pci probe function that will call usb_hcd_pci_probe
> to register its usb-2 bus, and then continue to manually register the
> usb-3 bus. usb_hcd_pci_probe does a pm_runtime_put_noidle at the end and
> might thus trigger a runtime suspend before the usb-3 bus is ready.
>
> Prevent the runtime suspend by increasing the usage count in the
> beginning of xhci_pci_probe, and decrease it once the usb-3 bus is
> ready.
>
> xhci-platform driver is not using usb_hcd_pci_probe to set up
> busses and should not need to have it's usage count increased during probe.
>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>

Acked-by: Dan Williams <dan.j.williams@intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/